ENH: Add edge-regressors to confounds & crown to carpetplot #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2022
Merged
celprov
force-pushed
the
enh/edge-regressor
branch
4 times, most recently
from
c85b8dd
to
196459d
Compare
oesteban
force-pushed
the
enh/edge-regressor
branch
from
196459d
to
2b3b9c9
Compare
…nd compute edge-regressor using AcompCor with the crown mask
…tion call get_dilated_brainmask()
oesteban
force-pushed
the
enh/edge-regressor
branch
from
2b3b9c9
to
a22b7f5
Compare
oesteban
force-pushed
the
enh/edge-regressor
branch
from
6839905
to
e247105
Compare
oesteban
changed the title
|
(please do not merge yet, even if all tests go green - I have to push a commit updating the generated boilerplate, the report template and adding Patriat's citation) |
…e, and adding Patriat's citation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add edge-regressors as new confounds written out by fMRIPrep.
The edge-regressors are computed by feeding ACompCor the crown mask extracted using the interface coded in the niworkflows repository. In that aim, a node for crown extraction and a node for ACompCor calculation with the crown mask are integrated in the confounds workflow.
IMPORTANT ! : This piece of code depends on the change in the niworkflow repositories commited under the pull request nipreps/niworkflows#651.
Closes #1634
Documentation that should be reviewed
Documentation should be already updated.