Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Oct 2, 2025

Follow up on #3461 to include template information

Sampler boilerplate text

The BOLD time-series were resampled onto the left/right-symmetric template “fsLR” using the Connectome Workbench (Glasser et al. 2013). The BOLD time-series were resampled onto the native surface of the subject using the “ribbon-constrained” method and then dilated by 10 mm.Grayordinates files (Glasser et al. 2013) containing 91k samples were also generated with surface data transformed directly to fsLR space and subcortical data transformed to 2 mm resolution MNI152NLin6Asym space. The BOLD series was resampled to OpenNeuro Average (onavg) surface template [Feilong et al. (2024); TemplateFlow ID: onavg] using the Connectome Workbench. All resamplings can be performed with a single interpolation step by composing all the pertinent transformations (i.e. head-motion transform matrices, susceptibility distortion correction when available, and co-registrations to anatomical and output spaces). Gridded (volumetric) resamplings were performed using nitransforms, configured with cubic B-spline interpolation. Non-gridded (surface) resamplings were performed using the Connectome Workbench.Grayordinate “dscalar” files containing 91k samples were resampled onto fsLR using the Connectome Workbench (Glasser et al. 2013).

@mgxd mgxd changed the title Rf/bold surf resample DOC: Include template metadata information when resampling BOLD to surface Oct 2, 2025
@effigies effigies added this to the 25.2.x (LTS) milestone Oct 2, 2025
@effigies
Copy link
Member

effigies commented Oct 2, 2025

Feilong et al. (2024); TemplateFlow ID: onav

Should be "Ma et al.", no?

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.92%. Comparing base (bdd07c9) to head (d88a28f).
⚠️ Report is 21 commits behind head on maint/25.2.x.

Files with missing lines Patch % Lines
fmriprep/workflows/bold/resampling.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/25.2.x    #3544      +/-   ##
================================================
- Coverage         72.98%   72.92%   -0.07%     
================================================
  Files                60       60              
  Lines              4813     4817       +4     
  Branches            624      625       +1     
================================================
  Hits               3513     3513              
- Misses             1158     1162       +4     
  Partials            142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd
Copy link
Collaborator Author

mgxd commented Oct 2, 2025

Looks like that's how it is formatted in the paper - https://www.nature.com/articles/s41592-024-02346-y

cc @feilong

@feilong
Copy link
Contributor

feilong commented Oct 2, 2025

Sorry for the confusion. I use a different order of my name in publications. Feilong et al. is good.

@effigies
Copy link
Member

effigies commented Oct 2, 2025

mm.Grayordinates

I think we're missing a space.

@effigies effigies merged commit 8867c9d into nipreps:maint/25.2.x Oct 3, 2025
21 of 23 checks passed
@mgxd mgxd deleted the rf/bold-surf-resample branch October 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants