Skip to content

Conversation

effigies
Copy link
Member

@effigies effigies commented Dec 4, 2021

I set skip-string-normalization just to avoid automatic formatters from making unnecessary changes and polluting PRs. Probably not relevant since you've already converted, so I can remove it if you prefer.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Merging #162 (6c82415) into master (5db88ae) will decrease coverage by 0.04%.
The diff coverage is 29.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   32.58%   32.53%   -0.05%     
==========================================
  Files          44       44              
  Lines        3609     3645      +36     
==========================================
+ Hits         1176     1186      +10     
- Misses       2433     2459      +26     
Impacted Files Coverage Δ
nibabies/cli/parser.py 2.32% <0.00%> (-0.17%) ⬇️
nibabies/interfaces/confounds.py 58.47% <ø> (ø)
nibabies/interfaces/freesurfer.py 41.53% <ø> (ø)
nibabies/interfaces/multiecho.py 78.57% <ø> (ø)
nibabies/interfaces/workbench.py 88.40% <ø> (ø)
nibabies/utils/bids.py 22.00% <0.00%> (-0.92%) ⬇️
nibabies/utils/confounds.py 3.92% <ø> (ø)
nibabies/workflows/anatomical/base.py 8.69% <0.00%> (-0.20%) ⬇️
nibabies/workflows/base.py 11.11% <ø> (ø)
nibabies/workflows/bold/base.py 13.98% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833092...6c82415. Read the comment docs.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much needed

@mgxd mgxd merged commit eee9359 into nipreps:master Dec 4, 2021
@mgxd mgxd added this to the 22.0.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants