FIX: Relabel sub-structures before discarding #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses problem raised in nipreps#149 Initial implementation using a custom `Function`, but this may be worth a proper interface.
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 32.10% 33.36% +1.26%
==========================================
Files 45 45
Lines 3728 3779 +51
==========================================
+ Hits 1197 1261 +64
+ Misses 2531 2518 -13
Continue to review full report at Codecov.
|
mgxd
force-pushed
the
enh/cifti-robustness
branch
from
ffa6b4b to
20d0517
Compare
Since nibabel interfaces have been ported over, they can be removed from this codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problem raised in #149
Initial implementation using a customFunction, but this may be worth a proper interface.Adds a new interface,MapLabels, to handle label remapping.Interfaces within
nibabies.interfaces.nibabel(BinaryDilation,MergeROIs, andMapLabelswere ported into niworkflows 1.5.0.Adds label remapping step to CIFTI generation.