Skip to content

Conversation

celprov
Copy link
Contributor

@celprov celprov commented Aug 4, 2023

Hey,
I would like to add my OHBM23 presentation in the list of educational resources available.
However, it's a PDF so it requires some tricks to get rendered.

I tried to follow the guidelines from here without success so far.
Any idea?

Additionally, I was thinking to add a link to the recording that I will post on Youtube. WDYT @oesteban ?

@oesteban
Copy link
Member

oesteban commented Aug 7, 2023

I don't get why you want to see the PDF embedded. I guess you want it to provide the same experience of the other slides, but those are not PDF; those are HTML.

I think you should just upload the pdf file (you did) and link it.

@celprov celprov force-pushed the enh/ohbm23educational branch from 7e5f6a6 to fbb1360 Compare August 21, 2023 17:33
@celprov
Copy link
Contributor Author

celprov commented Aug 21, 2023

@oesteban ok that was easy to solve ^^'
Let's merge this and I will add the video in another PR.

@celprov celprov marked this pull request as ready for review August 21, 2023 19:46
@celprov celprov requested review from oesteban and esavary August 21, 2023 19:47
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. Once that's fixed, please go ahead and merge.

Co-authored-by: Oscar Esteban <code@oscaresteban.es>
@celprov
Copy link
Contributor Author

celprov commented Aug 21, 2023

@oesteban Thanks ! It is done. However, I don't have merging rights it seems. Can you do it?

@oesteban oesteban merged commit d269b7d into nipreps:mkdocs Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants