-
Notifications
You must be signed in to change notification settings - Fork 13
Actions away! #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bendhouseart
wants to merge
18
commits into
main
Choose a base branch
from
add-persistant-test-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Actions away! #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reviewers in anticipation of the action in |
effigies
reviewed
Sep 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Adding actions to download and then run petprep on downloaded test data. "Caching" data locally on self hosted runner.
Creates two new workflows:
Collect data is the more important of the two as it's set up to be called by other actions to either acquire or check to see if test data is already present on the runner. Uses
scripts/collect_test_data.py
to retrieve said data. There's additional work to be done the ensure that downloaded data that's stored locally is in a "clean state" since it persists on disk. It might be best to make the data read only after download then copy over to the an actions working directory via the parent caller.run_petprep.yml
builds and runs petprep on bare metal on the data collected viacollect_data.yml/collect_test_data.py
and plays two parts:collect_data.yml
by checking if the data there is amenable to petprepI'm anticipating significant changes to each one of these actions, but wanting to get them merged so that we have a baseline to improve upon. Currently these actions only run on a single self hosted runner and won't bump heads against anything else.
Documentation that should be reviewed