MRG: Py3k support #152
MRG: Py3k support #152
Conversation
|
Can you build the mne doc with it? |
|
I have some annoying backend conflicts with |
|
|
||
| needed_deps = ["IPython", |
There was a problem hiding this comment.
I don't know why we had IPython listed as a dependency... @mwaskom looks like this was your change any idea?
There was a problem hiding this comment.
The pysurfer command line tool drops you into IPython. Also in general you need IPython to do any interactive work.
There was a problem hiding this comment.
The pysurfer command line tool drops you into IPython.
Then it should be an optional dependency, not a hard requirement. People (like me) who do import surfer and do everything from there shouldn't need to have IPython.
Also in general you need IPython to do any interactive work.
I disagree -- I use python -i (effectively) from Spyder in general, and rarely (if ever) use IPython, and have no problems with interactivity.
There was a problem hiding this comment.
Ok. I don't particularly care about declaring it as a dependency...
There was a problem hiding this comment.
Cool. Any other comments? If not I think it should be good to merge.
|
Changes Unknown when pulling a079c22 on Eric89GXL:py3k into * on nipy:master*. |
|
LGTM |
|
Thanks for the quick reviews. Now everyone gets to have fun building the VTK and Mayavi :) |
|
Forgot to say cheers for doing the boring work here! (But also, sotto voce boos for removing my main excuse for not switching to Python 3). |
|
no pain installing mayavi on your mac michael?
|
|
That's my current supplementary excuse. I haven't actually tried to use it yet :) |
Brings PySurfer py3k support. No CI support yet because Anaconda packages don't exist yet. But tests pass on my system with Mayavi dev and VTK 7.0.
Closes #143.