[MRG] ENH: Set initial time in Brain.add_data() #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM +1 for merge if you're done. |
|
Updated the example. If others agree with the API then this is ready. |
|
LGTM |
| @@ -857,6 +858,8 @@ def add_data(self, array, min=None, max=None, thresh=None, | |||
| conserving memory when displaying different data in a loop. | |||
| time_label_size : int | |||
| Font size of the time label (default 14) | |||
| initial_time : float | |||
There was a problem hiding this comment.
| None
and describe it means the first time point will be used
|
Otherwise LGTM, but you should probably also add a test that the parameter at least can be passed in |
christianbrodbeck
force-pushed
the
add_data
branch
from
feb24d6 to
8a77e28
Compare
|
Ready and tests pass, added test and doc. |
christianbrodbeck
changed the title
| stc['tmin'] + data.shape[1] * stc['tstep'], | ||
| data.shape[1]) | ||
| time = np.linspace(stc['tmin'], stc['tmin'] + data.shape[1] * stc['tstep'], | ||
| data.shape[1]) |
There was a problem hiding this comment.
The endpoint needs to be stc['tmin'] + (data.shape[1] - 1) * stc['tstep'] right?
|
Otherwise LGTM |
|
Good catch @Eric89GXL |
|
Thanks @christianbrodbeck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on mne-tools/mne-python#3375 CC @jaeilepp @Eric89GXL