TEST: use pytest tmpdir fixture #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jun 3, 2018
surfer/tests/test_utils.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| import nose.tools as nt | |||
| from numpy.testing import assert_array_almost_equal, assert_array_equal | |||
|
|
|||
| from surfer.testing import requires_fsaverage | |||
There was a problem hiding this comment.
I would not make testing a public module.
|
appveyor is not happy |
|
I think appveyor is generally unhappy, something about setting up the environment... |
|
Let me iterate in #244 to get AppVeyor working again then we can re-run this, since it touches some code that was specific to the windows platform. |
|
Sorry @christianbrodbeck I broke this a bit :( Do you have time to rebase? If not I can do it and push |
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 74.98% 74.93% -0.06%
==========================================
Files 7 7
Lines 2479 2474 -5
Branches 494 493 -1
==========================================
- Hits 1859 1854 -5
Misses 447 447
Partials 173 173 |
|
Rebased and all green... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating files in the repository during testing.