ENH Brain.add_label(): find labels in subfolder

[christianbrodbeck]

This would allow

brain.add_label('superiortemporal', subdir='aparc')

[agramfort]

LGTM

[mwaskom]

I like the general idea here, but I'm not wild about the implementation. That looks a lot like a path, but it's not treated as a path. Seems like it could be very confusing.

Other options would be

• brain.add_label(('aparc', 'superiortemporal'))
• brain.add_label('superiortemporal', subdir='aparc')

With some preference for latter, but I'm open to other options too.

[christianbrodbeck]

If nobody else wants to weigh in should I just add the subdir argument?

[larsoner]

I also have a preference for the latter subdir method, because I generally
try to avoid passing tuples as an argument when they can be meaningfully
broken out as separate (keyword) arguments.

[agramfort]

fine with me

+1 for merge on my side

[mwaskom]

Won't this fail when subdir is None?

[christianbrodbeck]

Sorry I was too quick!

On Jan 25, 2014, at 12:39 PM, Michael Waskom notifications@github.com wrote:

In surfer/viz.py:

@@ -1030,6 +1033,7 @@ def add_label(self, label, color="crimson", alpha=1,
filepath = pjoin(self.subjects_dir,
self.subject_id,
'label',

•                             subdir,
  

  Won't this fail when subdir is None?

—
Reply to this email directly or view it on GitHub.

[christianbrodbeck]

Updated the code and the DOC, better?

[mwaskom]

Thanks!