ENH Brain.add_label(): use the label.hemi and label.color attributes

[christianbrodbeck]

When plotting Label instance, use the label.hemi attribute

[larsoner]

Can hemi be None coming from mne-python? I can't remember...

[christianbrodbeck]

I don't think so, mne.read_label() contains

    if basename.endswith('lh.label') or basename.startswith('lh.'):
        hemi = 'lh'
    elif basename.endswith('rh.label') or basename.startswith('rh.'):
        hemi = 'rh'
    else:
        raise ValueError('Cannot find which hemisphere it is. File should end'
                         ' with lh.label or rh.label')

and Label.__init__()

        if not isinstance(hemi, string_types):
            raise ValueError('hemi must be a string, not %s' % type(hemi))

(wouldn't it make more sense to check it's in ('lh', 'rh')?)

[larsoner]

Cool. I think the current check (lh.label end or lh. start) was designed to follow a standard naming mechanism, likely because it's what freesurfer expects / can handle.

[christianbrodbeck]

I meant "(wouldn't it make more sense to check it's in ('lh', 'rh')?)" applying to Label.__init__()

[larsoner]

I'm not sure where you mean... Label.__init__() in mne-python?

[christianbrodbeck]

Ah yes, Label.__init__() in mne-python has the lines

        if not isinstance(hemi, string_types):
            raise ValueError('hemi must be a string, not %s' % type(hemi))

And I was wondering why not checking that it's "lh" or "rh"

[larsoner]

Not sure, maybe because we support adding the attribute later manually?

[christianbrodbeck]

But then wouldn't we allow None instead of a random string?

On Jan 30, 2014, at 8:09 PM, Eric89GXL notifications@github.com wrote:

In surfer/viz.py:

@@ -1052,7 +1052,7 @@ def add_label(self, label, color="crimson", alpha=1, scalar_thresh=None,
else:
# try to extract parameters from label instance
try:

•            lhemi = label.hemi
  

•            hemi = label.hemi
  

  Not sure, maybe because we support adding the attribute later manually?

—
Reply to this email directly or view it on GitHub.

[christianbrodbeck]

I took the opportunity to also use the new mne-python label.color attribute (mne-tools/mne-python#1111)

[agramfort]

matplotlib-style color | None

[agramfort]

besides my nitpick LGTM

[christianbrodbeck]

Updated the DOC as suggested by @agramfort

[agramfort]

thx