-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper fixes for JOSS review #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve changes but would like to address other items listed in PR description before merging.
Thank you @britta-wstnr
Thank you for taking time to provide feedback to improve the paper.
I approved
AFAIK Wodder doesn't have ORCID, so intended. For Todd -- inquired in #754 and will give him a few days to reply.
I only found him missing middle initial
well -- it is when the project started, then in subsequent years there were refinements etc, and it never "finished". So we kept the date open: limiting to 2003 (inception) would be somewhat misleading, specifying 2004 when poster appeared would also be incomplete.
IMHO it doesn't matter really, but if you like we could move. Done in 954c159 . But also that publication is now published, so replaced arxiv citation with full fledged publication in 0ee9585
ok, split into two sentences, and pushed to this branch for review
indeed! thanks for spotting. proposed fix pushed in this branch along with prior change in 26072be
Well -- the Figure caption went into describing a hypothetical setup with the 3rd machine which is not depicted on the Figure. So in the 2-machine solution there is no such 3rd machine. If you really dislike this sentence which is not per describing the Figure content, we can just remove the sentence. Please advise. |
Hi @yarikoptic, looks all good to me.
|
Thank you -- took your version. I think now we can proceed with this PR. I will leave it up to you to decide on either to wait on IMHO it is ok to proceed as is. |
This PR is done within the reviewing process over at openjournals/joss-reviews#5839
@yarikoptic, I fixed some small things in the paper - please check if you agree that this might help readability.
Other things I came across:
Gorgolewski et al
: due to different initials in the bibliography, the intitials occur in the reference in the text. Please check if that is correct/on purpose.NIfTI Data Format
has a funny year ("2003--") - please double check.Poldrack et al. 2004
at the right place? Should it be moved to after "one of the challenges"? (State of the field, first sentence, line 84)And then there is three sentences that maybe could be made clearer (at least I stumbled when reading them):
Maybe the sentence could be re-written (or split) to prevent the repetition of "while"?
I think this sentence is missing a main sentence part?
Maybe it could be made clearer which of the machines is dedicated to data reposition?