BF: _on_mouse and _on_scroll in viewers for non RAS matrices
#1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct `_on_mouse`and `on_scroll` method
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
+ Coverage 95.34% 95.36% +0.02%
==========================================
Files 207 207
Lines 29507 29645 +138
Branches 4982 4985 +3
==========================================
+ Hits 28134 28272 +138
Misses 932 932
Partials 441 441 ☔ View full report in Codecov by Sentry. |
gjpcbecq
changed the title
_on_mouse and _on_scroll in viewers for non RAS matrices
gjpcbecq
changed the title
_on_mouse and _on_scroll in viewers for non RAS matrices
gjpcbecq
changed the title
_on_mouse and _on_scroll in viewers for non RAS matrices
effigies
approved these changes
Sep 23, 2024
|
You are welcome Chris 🙇♂️ thanks for your great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have corrected indices for matrices with flipped dimensions.
I have also corrected the ordering of RAS dimensions when order of the RAS are different in the data array.
Perhaps all the code need to be refactored for clarity, using only affine transforms from the viewer to the RAS coordinate system then RAS to ijk, avoiding confusing flipping and reordering.
Perhaps I will look about that, if I have time.