-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ecat test data set with negative values #297
Conversation
Great - thanks for this. Do you somewhere have the minimum value in image, as it should be (if we weren't messing up the negative numbers)? I'm thinking how to test we've got it right in due course. |
@freec84 - do you have any metrics from the correctly loaded data to help with tests? Like min, max, mean etc? If not - let me know anyway? Then I'll do my best to fix this without. |
Hi Matthew, the metrics are: min: -0.00061576 Bests, On 28/02/15 20:47, Matthew Brett wrote:
|
MRG: added ecat test data set with negative values I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data. It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load. Correct values when loaded are: min: -0.00061576 max: 0.19215 mean: 0.04933 unit: 1/cm
Would you mind having a look at #302 - it should fix your problem, and gives the same answers as you give above. |
Thanks a lot Matthew. You fix works. Negative values are now read in correctly. |
BF+TST: test /fix for signed int data type We were incorrectly loading signed ints as unsigned; fix and test. See gh-297 for motivation.
MRG: added ecat test data set with negative values I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data. It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load. Correct values when loaded are: min: -0.00061576 max: 0.19215 mean: 0.04933 unit: 1/cm
BF+TST: test /fix for signed int data type We were incorrectly loading signed ints as unsigned; fix and test. See nipygh-297 for motivation.
I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data.
It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load.