Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ecat test data set with negative values #297

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

freec84
Copy link
Contributor

@freec84 freec84 commented Feb 21, 2015

I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data.
It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.33% when pulling cced39e on freec84:add-pet-data-submodule into 96d474c on nipy:master.

@matthew-brett
Copy link
Member

Great - thanks for this. Do you somewhere have the minimum value in image, as it should be (if we weren't messing up the negative numbers)? I'm thinking how to test we've got it right in due course.

@matthew-brett
Copy link
Member

@freec84 - do you have any metrics from the correctly loaded data to help with tests? Like min, max, mean etc? If not - let me know anyway? Then I'll do my best to fix this without.

@freec84
Copy link
Contributor Author

freec84 commented Mar 1, 2015

Hi Matthew,

the metrics are:

min: -0.00061576
max: 0.19215
mean: 0.04933
unit: 1/cm

Bests,
Georg

On 28/02/15 20:47, Matthew Brett wrote:

@freec84 https://github.com/freec84 - do you have any metrics from the
correctly loaded data to help with tests? Like min, max, mean etc? If
not - let me know anyway? Then I'll do my best to fix this without.


Reply to this email directly or view it on GitHub
#297 (comment).

matthew-brett added a commit that referenced this pull request Mar 26, 2015
MRG: added ecat test data set with negative values

I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data.
It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load.

Correct values when loaded are:

min: -0.00061576
max:  0.19215
mean: 0.04933
unit: 1/cm
@matthew-brett matthew-brett merged commit cf4f946 into nipy:master Mar 26, 2015
@matthew-brett
Copy link
Member

Would you mind having a look at #302 - it should fix your problem, and gives the same answers as you give above.

@freec84
Copy link
Contributor Author

freec84 commented Mar 29, 2015

Thanks a lot Matthew. You fix works. Negative values are now read in correctly.

matthew-brett added a commit that referenced this pull request Apr 20, 2015
BF+TST: test /fix for signed int data type

We were incorrectly loading signed ints as unsigned; fix and test.

See gh-297 for motivation.
grlee77 pushed a commit to grlee77/nibabel that referenced this pull request Mar 15, 2016
MRG: added ecat test data set with negative values

I added a ecat7 file with negative values (transmission scan from ecat exac hr+ pet scanner) to the test data.
It seems that alls negative values are set to two times the maximum positive value when read in with nibabel ecat load.

Correct values when loaded are:

min: -0.00061576
max:  0.19215
mean: 0.04933
unit: 1/cm
grlee77 pushed a commit to grlee77/nibabel that referenced this pull request Mar 15, 2016
BF+TST: test /fix for signed int data type

We were incorrectly loading signed ints as unsigned; fix and test.

See nipygh-297 for motivation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants