TEST: Convert remainder of nibabel.tests to pytest #876
Conversation
Codecov Report
@@ Coverage Diff @@
## pytest #876 +/- ##
==========================================
+ Coverage 89.74% 91.51% +1.77%
==========================================
Files 97 97
Lines 12403 12403
Branches 2185 2185
==========================================
+ Hits 11131 11351 +220
+ Misses 926 708 -218
+ Partials 346 344 -2
Continue to review full report at Codecov.
|
|
@djarecka The diff seems to have gotten full of commits from the main branch. Next time you commit, could you merge or rebase onto the latest No rush though. I'm going to stop fiddling with nibabel and do real work for the rest of the day. |
|
@effigies - that's what I tried to do, but apparently I failed... by main branch, you mean |
|
Yup, Merging or rebasing usually resolves it. |
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
djarecka
force-pushed
the
pytest_updates
branch
from
9ee2408
to
a21c083
Compare
| return skipif(not have_files, | ||
| "Need files in {0} for these tests".format(required_path)) | ||
| return pytest.mark.skipif(not have_files, | ||
| reason="Need files in {0} for these tests".format(required_path)) |
There was a problem hiding this comment.
Because this is now a pytest.mark.skipif, nose isn't skipping these. You should grep for @needs_nibabel_data, and any files that use it should be added to the ignore list.
|
@effigies - ready to review. |
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
|
ok, I think I addressed everything |
effigies
changed the title
I was continuing wit tests from
nibabel.tests. I finished them, but I have to:address Chris comments to my old PR
it looks like that in Nov I haven't removed allit looks fine after checkingyieldstatement carefully, so have to come back to it