-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add duecredit entries #1466
Conversation
# Use duecredit (duecredit.org) to provide a citation to relevant work to | ||
# be cited. This does nothing, unless the user has duecredit installed, | ||
# And calls this with duecredit (as in `python -m duecredit script.py`): | ||
due.cite(Doi("10.3389/fninf.2011.00013"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should now be replaced with the zenodo doi.
Hi @satra, thanks! The zenodo DOI changes for each version, doesn't it? Wouldn't it be a good idea to put both references, the paper that is already there and also the Zenodo DOI? |
yes - we can update the zenodo reference with each release. we can have both doi's in there. |
I hope you don't mind I go slowly with this. I had a problem with duecredit and the Zenodo DOI. I have one question though...some nodes have references depending on trait values. Such as: Do you think I should go deep as checking trait values to know what to cite? |
@alexsavio - take your time with this or we can try to figure out a way to crowdsource this. regarding your question about trait_values, due you think we could simply do this based on doi? then we can add a metadata field to the interface called dois, which we can update in such a case. we can add the doi extraction via duecredit during the help generation or runtime. |
Hi @satra, thanks for the follow-up. I have been reading the duecredit tests to understand it. I am thinking if we should keep all the citations together in one file in nipype or we should use decorators all around the code base. Given the size of nipype, IMO the "one file" approach would be easier to maintain and would keep the rest of the code base clean. If the extra fields in the dcite function work well, this could be possible. More info below: Following @arokem approach, apart from the DOI, he is using 3 more fields more for each citation: description, tags and path.
And there is another field called There is some environment variables that can be implemented: I would add: |
Yes - I got that from @yarikoptic (thanks again!). For the record, as I just discovered yesterday, you can also give it a full On Wed, May 4, 2016 at 8:27 AM, Alexandre M. S. notifications@github.com
|
I have sent a quick PR resolving some of the issues here... see alexsavio#8 |
Fix up import of version info from nipype/info.py
and one more PR for completeness: alexsavio#9 but you might not agree or decide to invoke it differently (i.e. without growing number of travis runs) ;-) |
ENH: travis -- add a run which would execute with DUECREDIT_ENABLE
…hout relative imports
…hout relative imports
…hout relative imports
@satra I just did a PR to @alexsavio repository. This version merge master to this PR, and fix the bugs that were preventing it to pass the integration tests. |
enh/duecredit
This PR is related with #1464.
This is a WIP, I will be adding DOI entries to the code base.
Any help, comment or suggestion is appreciated.
With this first commit, I get:
$ python -m duecredit examples/test_spm.py