Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: FSL orthogonalization bug #2523

Merged
merged 2 commits into from
Apr 1, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented Apr 1, 2018

@jokedurnez This is the fix you suggested in #2073. I'm reading the second comment in that thread as verification that it successfully did what you intended, but I just want to double-check.

Fixes #2073.

Changes proposed in this pull request

  • Cherry-picked @jokedurnez's commit
  • Minor refactor to reduce number of times the same string is calculated, and satisfy PEP8

@codecov-io
Copy link

codecov-io commented Apr 1, 2018

Codecov Report

Merging #2523 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2523      +/-   ##
==========================================
- Coverage   66.88%   66.88%   -0.01%     
==========================================
  Files         327      327              
  Lines       42479    42482       +3     
  Branches     5268     5269       +1     
==========================================
  Hits        28413    28413              
- Misses      13365    13367       +2     
- Partials      701      702       +1
Flag Coverage Δ
#smoketests 50.84% <75%> (ø) ⬆️
#unittests 64.22% <50%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/model.py 80.42% <75%> (-0.04%) ⬇️
nipype/interfaces/spm/base.py 86.79% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539930e...22fd9ff. Read the comment docs.

@oesteban oesteban merged commit c6ac7a6 into nipy:master Apr 1, 2018
@effigies effigies added this to the 1.0.3 milestone Apr 1, 2018
@effigies effigies deleted the fix/fsl_orthogonalization branch April 2, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] orthogonalisation on/off
4 participants