MNT: Consolidate build metadata in pyproject.toml #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks good to me. I like setuptools_scm, but just haven't gotten around to adding it here. Should we go ahead and merge this first? |
effigies
force-pushed
the
mnt/pyprojectify
branch
from
df16fd7 to
23876b1
Compare
effigies
force-pushed
the
mnt/pyprojectify
branch
from
23876b1 to
f30a4db
Compare
|
Done. And wheels are built, showing that versions are correctly determined. (Assuming you like the default version scheme.) |
|
Awesome. Thanks! I guess I should cut another micro release once this is in place. |
|
I'm definitely not in a rush. If it waits until 3.12 is out along with numpy wheels, that'd be fast enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My primary goal is actually to remove
cythonfrom the install-time dependencies, but one thing led to another...Let me know what you think. I can scale back, if you prefer to keep more of the build metadata as runtime variables in nitime.
Another thing we can consider is getting rid of
version.pyaltogether and using setuptools_scm to generate the version automatically. Would seem excessive given the rare releases, but it's only a couple lines and would further consolidate metadata for the future.I also anticipate wanting to make sure there's a 3.12 wheel once numpy starts distributing them.