Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting adding absolute_path #489

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

JeffWigger
Copy link

@JeffWigger JeffWigger commented Jul 6, 2021

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Discussed reversion of the addition of absolute_path. Also as discussed, support for outputs with absolute paths will be readded later (Not in this PR) without the need to explicitly set the absolute_path option.
This reversion broke the test test_shell_cmd_outputspec_8d. I rewrote it such that it does not need an absolute path in the outputs.

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #489 (6ddae3b) into master (07a8074) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   83.00%   82.94%   -0.07%     
==========================================
  Files          20       20              
  Lines        4037     4033       -4     
  Branches     1117     1115       -2     
==========================================
- Hits         3351     3345       -6     
- Misses        491      492       +1     
- Partials      195      196       +1     
Flag Coverage Δ
unittests 82.86% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/specs.py 88.13% <ø> (-0.12%) ⬇️
pydra/engine/helpers_file.py 79.49% <100.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a8074...6ddae3b. Read the comment docs.

@djarecka djarecka merged commit 404b579 into nipype:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants