Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make ObjectExtensions internal or define it in a custom namespace #700

Closed
wjrogers opened this issue Nov 23, 2021 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@wjrogers
Copy link

In NPOI 2.5.5, you added these public extension methods in the System namepace: a3058a2. All consumers of NPOI are now forced to import these extension methods with the System namespace. Please consider changing the visibility of ObjectExtensions to internal or changing its namespace to e.g. NPOI.Util.

@tonyqus
Copy link
Member

tonyqus commented Nov 23, 2021

Sorry, it's my fault. This class definition is copied from stackoverflow.com or somewhere. You know Ctrl+C and Ctrl+V. I didn't pay much attention to the namespace at all. I'll change the namespace in the next release.

@tonyqus tonyqus added the bug label Nov 23, 2021
@tonyqus tonyqus self-assigned this Nov 23, 2021
@tonyqus tonyqus added this to the NPOI 2.5.6 milestone Nov 23, 2021
@tonyqus tonyqus closed this as completed Feb 13, 2022
@tonyqus tonyqus modified the milestones: NPOI 2.6.0, NPOI 2.5.6 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants