-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Drawing shape #1080
Fix Drawing shape #1080
Conversation
This change may break drawing.xml. Do you have any unit test or sample that I can take a look to make sure your code is really working. |
I am here. |
slightly more complicated example |
The test just read and write as below
|
fix shape id numbering
I added the shape's properties ID,Name |
Is this PR still in progress? I see a few changes during the past days. If so, please put WIP prefix in the title. |
This concludes the functionality I want to add. thank you |
In my environment (fork branch) I don't get such test errors. . . . What should I do? |
LGTM |
Hello
I made some read/write fixes and additions to drawing
please merge if you like
by google translate