Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drawing shape #1080

Merged
merged 14 commits into from
Jul 14, 2023
Merged

Fix Drawing shape #1080

merged 14 commits into from
Jul 14, 2023

Conversation

mino-alpha
Copy link
Contributor

Hello
I made some read/write fixes and additions to drawing

  1. Allowed duplicate grouping
  2. Made it possible to place multiple connectors in a group
  3. Enabled reading and writing of Bezier curves

please merge if you like
by google translate

@tonyqus
Copy link
Member

tonyqus commented May 11, 2023

This change may break drawing.xml. Do you have any unit test or sample that I can take a look to make sure your code is really working.

@mino-alpha
Copy link
Contributor Author

I am here.
2.sample.xlsx
1 sample.xlsx

@mino-alpha
Copy link
Contributor Author

slightly more complicated example
3.sample.xlsx

@mino-alpha
Copy link
Contributor Author

The test just read and write as below

		IWorkbook oWB = WorkbookFactory.Create( "sample.xlsx" );

		var fs = new FileStream( "sample-w.xlsx", FileMode.Create );
		oWB.Write( fs, true );
		oWB.Close();
		fs.Close();

@mino-alpha
Copy link
Contributor Author

I added the shape's properties ID,Name

@tonyqus
Copy link
Member

tonyqus commented Jun 12, 2023

Is this PR still in progress? I see a few changes during the past days. If so, please put WIP prefix in the title.

@mino-alpha
Copy link
Contributor Author

This concludes the functionality I want to add. thank you

@tonyqus tonyqus added this to the NPOI 2.6.2 milestone Jun 14, 2023
@mino-alpha
Copy link
Contributor Author

In my environment (fork branch) I don't get such test errors. . . . What should I do?

@tonyqus
Copy link
Member

tonyqus commented Jul 14, 2023

LGTM

@tonyqus tonyqus merged commit 035f817 into nissl-lab:master Jul 14, 2023
@tonyqus tonyqus modified the milestones: NPOI 2.7.0, NPOI 2.6.2 Aug 31, 2023
@tonyqus tonyqus changed the title Drawing shape Fix Drawing shape Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants