Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux font installation with proper NotoColorEmoji-Regular.ttf #1124

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix Linux font installation with proper NotoColorEmoji-Regular.ttf #1124

merged 1 commit into from
Aug 12, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Jul 23, 2023 •
edited
Loading

Now using proper (twice the size) version of Noto Emoji font that has proper tables that SixLabors.Fonts expects. Also removed caching step as most of the dependencies are already installed and I/O is expensive on VM hosts.

@lahma lahma force-pushed the fix-linux-font-again branch 12 times, most recently from b7348e0 to e9cb51e Compare July 26, 2023 05:54
@Bykiev
Copy link
Collaborator

Bykiev commented Jul 26, 2023

Not sure on 100% (I'm not a Linux guy) but tests on linux could be failed because SixLabors.Fonts only searching in theses locations:

"%HOME%/.fonts/",
"/usr/local/share/fonts/",
"/usr/share/fonts/",

In the upcoming update "%HOME%/.local/share/fonts/" will be added SixLabors/Fonts#336

@lahma
Copy link
Collaborator Author

lahma commented Jul 26, 2023

It seems that the default font that comes from apt installation is broken w.r.t. to font tables available. I tried to open the TTF font from my own WSL Ubuntu installation and it doesn't open properly in Windows either. Trying now to replace it with proper one.

@lahma lahma force-pushed the fix-linux-font-again branch 3 times, most recently from 486b0ea to 62b174d Compare July 26, 2023 07:38
@lahma lahma changed the title Fix Linux font installation Fix Linux font installation with proper NotoColorEmoji-Regular.ttf Jul 26, 2023
@lahma
Fix Linux font installation with proper NotoColorEmoji-Regular.ttf
cb87b57 
* remove package caching
* fix test case to be windows dependent
@lahma lahma marked this pull request as ready for review July 26, 2023 07:58
@lahma
Copy link
Collaborator Author

lahma commented Jul 26, 2023

BTW, not sure if the appveyor build makes difference to have around anymore.

@lahma
Copy link
Collaborator Author

lahma commented Jul 26, 2023

Reported findings to SixLabors/Fonts: SixLabors/Fonts#346

@tonyqus
Copy link
Member

tonyqus commented Jul 26, 2023

https://docs.closedxml.io/en/latest/tips/missing-font.html

@lahma
Copy link
Collaborator Author

lahma commented Jul 27, 2023

https://docs.closedxml.io/en/latest/tips/missing-font.html

I think this is a bit different case. That page describes missing font when this PR tries to fix found, but invalid font.

@tonyqus
Copy link
Member

tonyqus commented Aug 12, 2023

I'll merge this first to see if it works

@tonyqus tonyqus merged commit 0e0dda3 into nissl-lab:master Aug 12, 2023
@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bykiev Bykiev Bykiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NPOI 2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lahma @Bykiev @tonyqus