[POI-66083 & POI-66094] Support (FLOOR|CEILING).MATH & (VAR|STDEV).(P|S) functions #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakasa
changed the title
karakasa
changed the title
|
Definitely, BigDecimal is the best choice for high precision calculation. I don't recommend we implement it again. Instead, we can use exisitng nuget packages. There are some existing implementation on nuget Although ExtendedNumerics.BigDecimal doesn't have huge downloads, the author is actively working on this library. |
|
ok. Since you think an external |
This comment was marked as outdated.
This comment was marked as outdated.
|
LGTM |
tonyqus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1023
(FLOOR|CEILING).MATHsupport, and functions are registered throughNPOI.SS.Formula.Atp. The algorithm is different from that of POI, incl. a workaround due to CLR lackingBigDecimal.(VAR|STDEV).(P|S)support with implementations based on MSO's webpage.The added
MATHfunctions are superior to the existingFLOOR|CEILINGin NPOI because the latter don't have a mechanism of precision control. PortingBigDecimalmay be the ultimate answer as what is done in the apache/poi.I also found a bug in Excel (16717.20000) that produces wrong answer. See AF13 in the last two sheets, the answer should be 4 while Excel reports 2.