GetColumnWidth: no need to explore the whole sheet #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can definitely speed up the process but this change cannot meet the needs of every NPOI users. How about making it a configurable argument in configuration file? |
But what if we want to use it and not use it in the same project? How about an optional argument instead? (maxRows = 0 by default) Or another function GetColumnWidthFast? |
|
I like maxRows = 0 by default idea. Can you change your PR? |
|
Done! (Do you prefer optional int parameter = 0 or nullable int parameter? I chose the first one but I don't know if it harmonizes with your code!) |
|
@PatriceDargenton parameter = 0 is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetColumnWidth can be speeded up for big sheets if we explore for example only the first 100 rows!