gamnit: use the same code to limit fps than mnit and fix errors #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
This duplication could probably be avoided as only the name of the method `frame_full` changes. But the doal is also to fully replace `mnit` so the old module should be removed soon... Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
|
+1 |
|
you broke clients that set their fps with Int |
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
privat
added a commit
that referenced
this pull request
Dec 9, 2015
Fixed a few bugs in `mnit::mnit_fps`, a typo invalidated the value of `current_fps` and the use of long Ints were broken probably since they are tagged. Using floats should fix this last issue. Finally, the goal of this PR is to copy the module `mnit::mnit_fps` to `gamnit::limit_fps` and adapt it to the gamnit framework. There is some code duplication, but the mnit version should be deleted with the engine when gamnit is completed. Pull-Request: #1879 Reviewed-by: Jean Privat <jean@pryen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few bugs in
mnit::mnit_fps, a typo invalidated the value ofcurrent_fpsand the use of long Ints were broken probably since they are tagged. Using floats should fix this last issue.Finally, the goal of this PR is to copy the module
mnit::mnit_fpstogamnit::limit_fpsand adapt it to the gamnit framework. There is some code duplication, but the mnit version should be deleted with the engine when gamnit is completed.