Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

raksiv
Copy link
Member

@raksiv raksiv commented Jul 16, 2024

API Gateway Throttle
S3 Server Side Encryption
S3 Replicate

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitric-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 11:57pm

API Gateway Throttle
S3 Server Side Encryption
S3 Replicate
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a have a couple of suggestions.

Co-authored-by: Jye Cusch <jye.cusch@nitric.io>
Co-authored-by: Jye Cusch <jye.cusch@nitric.io>
Co-authored-by: David Moore <4121492+davemooreuws@users.noreply.github.com>
davemooreuws
davemooreuws previously approved these changes Jul 23, 2024
Co-authored-by: Elisse Lockhart <99988295+elisselockhart@users.noreply.github.com>
elisselockhart
elisselockhart previously approved these changes Jul 24, 2024
@raksiv raksiv requested a review from davemooreuws July 24, 2024 22:47
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just making some links direct

Co-authored-by: David Moore <4121492+davemooreuws@users.noreply.github.com>
Co-authored-by: David Moore <4121492+davemooreuws@users.noreply.github.com>
@raksiv raksiv merged commit 9b40949 into main Jul 25, 2024
@raksiv raksiv deleted the docs/tf-customize-guides branch July 25, 2024 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants