This repository was archived by the owner on May 20, 2025. It is now read-only.
Update aws cfg ephemeral templates for pulumi and terraform #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
raksiv
commented
Oct 22, 2024
raksiv
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jyecusch
suggested changes
Oct 22, 2024
docs/providers/terraform/aws.mdx
Outdated
Comment on lines
118
to
127
| # set a timeout of 15 seconds | ||
| # See lambda timeout values here: | ||
| # https://docs.aws.amazon.com/lambda/latest/dg/configuration-function-common.html#configuration-timeout-console | ||
| ephemeral-storage: 512 | ||
| # set a provisioned concurrency value | ||
| # For info on provisioned concurrency for AWS Lambda see: | ||
| # https://docs.aws.amazon.com/lambda/latest/dg/configuration-concurrency.html | ||
| timeout: 15 | ||
| # set a provisioned concurrency value | ||
| # For info on provisioned concurrency for AWS Lambda see: |
There was a problem hiding this comment.
Can you update the comments here, it looks like they weren't quite right before this PR so it's a good chance to clean them up
raksiv
force-pushed
the
docs/aws-cfg-ephemeral
branch
from
213c7a0 to
88ce6fc
Compare
add config to aws tf docs Apply suggestions from code review Co-authored-by: Jye Cusch <jye.cusch@nitric.io>
raksiv
force-pushed
the
docs/aws-cfg-ephemeral
branch
from
88ce6fc to
e7144c1
Compare
tjholm
approved these changes
Oct 23, 2024
jyecusch
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.