Run tests with and without direnv’s strict_env #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s used for linting, so should be available.
The files are not executable, tests should only be run via `pytest`, and some of them were incorrectly python2.
It seems unlikely that the “without” case will have any errors that the “with” case doesn’t, but it’s still a common use case and easy enough to parametrize.
amarshall
force-pushed
the
strict-env-test
branch
from
b7d0776
to
92eb255
Compare
|
I think that this needs a rebase to fix up the tests and then I'm happy to merge it. |
|
@bbenne10 Just rebased a few minutes ago and is green 🙂 |
|
And we're merged :) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #329.