Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #419

Closed
wants to merge 2 commits into from
Closed

Release 3.0.0 #419

wants to merge 2 commits into from

Conversation

bbenne10
Copy link
Contributor

We just released 2.5.0 yesterday, but it strikes me that removing API surface is actually a major version bump. I'm opening a PR to handle the release to discuss a major release (wouldn't have bothered for a minor or point release)

Yes, we have back compat but we should still bump the major and keep the back compat until next major release.

Note that I didn't use the existing scripts, so a tag will need to be created after merge (or some other inclusion).
The sha256 for fetchurl should be correct, however.

@bbenne10 bbenne10 requested a review from Mic92 November 27, 2023 13:53
@bbenne10 bbenne10 self-assigned this Nov 27, 2023
@bbenne10
Copy link
Contributor Author

I'd like to include #420 in this release, but that means we need to invalidate the hashes here.
It should be trivial and I'd still like to consider a major release.

@kingarrrt
Copy link
Contributor

Could you hold off a little bit? I've got another PR in the works that uses the hash of watched files as cache key. Should be with you later today.

@bbenne10
Copy link
Contributor Author

bbenne10 commented Nov 27, 2023

I'm still waiting for review on #420. You're not holding us up at all. Please, however, take #420's changes into account when planning your PR.

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2023

We can also release 2.5.1 to drop the warning and than we got no hurry to release 3.0.

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2023

This would be 2.5.1: #421

@bbenne10
Copy link
Contributor Author

That's just fine with me.

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2023

This is obsolete now.

@Mic92 Mic92 closed this Nov 27, 2023
@Mic92 Mic92 deleted the bump_version_3.0.0 branch November 27, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants