Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mq_timedreceive to ::nix::mqueue. #1966

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Added mq_timedreceive to ::nix::mqueue. #1966

merged 1 commit into from
Jan 11, 2023

Conversation

DavidCollard
Copy link
Contributor

Noticed when working on a project that mq_timedreceive is missing from the mqueue module.

Not entirely familiar with best practices around feature gating in tests - I feel like I might have messed up by not including a #[cfg(feature = "time")]. Would like a little guidance there.

@DavidCollard DavidCollard marked this pull request as ready for review January 11, 2023 02:59
asomers
asomers approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems allright to me. And you did the right thing with feature gating: we don't attempt to feature gate the functional tests at all. You can only run the tests with all features enabled.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 11, 2023

Build succeeded:

@bors bors bot merged commit ef70d9e into nix-rust:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidCollard @asomers