Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ruby 2.1.2 #26

Closed
wants to merge 1 commit into from

Conversation

michalmuskala
Copy link

Installation of jazz_hands is currently failing on ruby 2.1.2 because of it's dependencies - particularly pry-debugger which is currently broken for 2.1.2, because of it's dependency debugger. Even though debugger works with rubies 2.0 up to 2.1.1, it's not supposed to (more info here: cldwalker/debugger#125 (comment) and here cldwalker/debugger#125 (comment)). As ruby 2 is used more and more frequently this change might be beneficial.

@nixme
Copy link
Owner

nixme commented May 22, 2014

I agree, this whole situation basically sucks. However, my plan is to make pry-debugger not reliant on debugger (or byebug or debugger2) at all and thus have no dependencies. It barely uses much of their API and then could work with a whole range of rubies including jruby and rbx. Then pry-nav can be deprecated as well. See #11 for more discussion.

For now however, I recommend doing this following in your Gemfile:

gem 'jazz_hands', github: 'nixme/jazz_hands', branch: 'bring-your-own-debugger'
gem 'pry-byebug'

The bring-your-own-debugger branch removes the pry-debugger dependency.

@ricardodovalle
Copy link

👍
@nixme What do you think to create a new gem from branch: 'bring-your-own-debugger' ?

@timurvafin
Copy link

@nixme any updates here?

@scarfacedeb
Copy link

@timurvafin You can use my fork for now

@nixme
Copy link
Owner

nixme commented Jul 28, 2014

@ricardodovalle is there something preventing you from using the git-based Gemfile approach? The lockfile will lock to a specific revision and even bundle package works.

@plribeiro3000 plribeiro3000 mentioned this pull request Oct 16, 2014
@plribeiro3000
Copy link

Guys, take a look at jazz_fingers, its a maintained fork of this project and already include fixes for ruby > 2.0.0.

@ascendbruce
Copy link

Hey guys, also take look at awesome_rails_console. it is a similar project but with slightly different appearance and support Ruby 2.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants