Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode label is not automatically set yet #614

Closed
superherointj opened this issue Sep 21, 2022 · 5 comments
Closed

vscode label is not automatically set yet #614

superherointj opened this issue Sep 21, 2022 · 5 comments

Comments

@superherointj
Copy link

vscode label is not automatically set yet

@grahamc
Copy link
Member

grahamc commented Sep 21, 2022 via email

@superherointj
Copy link
Author

superherointj commented Sep 21, 2022

should it?

I think it should.
Vim, emacs have it.
There is a lot of vscode-extensions packages.
Why not?

Any changes in vscode folder (pkgs/applications/editors/vscode/) could trigger it.

@superherointj
Copy link
Author

superherointj commented Sep 21, 2022

There is a label already, OfBorg just doesn't set it automatically yet:

https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+is%3Apr+label%3A%226.topic%3A+vscode%22

@zowoq
Copy link
Contributor

zowoq commented Sep 21, 2022

Vim, emacs ..

These labels are managed in the nixpkgs repo: https://github.com/NixOS/nixpkgs/blob/master/.github/labeler.yml

ofborg only does the rebuild count and a couple of others:

const TITLE_LABELS: [(&str, &str); 3] = [
("bsd", "6.topic: bsd"),
("darwin", "6.topic: darwin"),
("macos", "6.topic: darwin"),
];

@superherointj
Copy link
Author

superherointj commented Sep 21, 2022

Oh. I did not know that. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants