Implemented default checkbox filter value #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IvanBernatovic would you please help to write a unit test? |
|
@njleonzhang Sure, I'll look into it and let you know more. I intend to work with this file which seems is related to checkboxes on client side, I'll also take the opportunity to test it with server side implementation and write unit test for that too. I'll try to work on it this week. Do you have anything else in mind or do you have any advice/suggestion? |
|
@IvanBernatovic You are right. just add unit test in checkFilter.spec.js for client side and checkFilter.spec.js for server side. |
|
default checkbox filter is removed in v3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this ticket. I tested it locally for client-side data-tables component and everything worked fine and data is properly filtered by default.