Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite recursion and empty nixpkgs #45

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Fix infinite recursion and empty nixpkgs #45

merged 3 commits into from
Apr 10, 2019

Conversation

nmattia
Copy link
Owner

@nmattia nmattia commented Apr 7, 2019

Fixes #39

@nmattia nmattia requested a review from nlewo April 7, 2019 17:59
nmattia
nmattia commented Apr 7, 2019
View reviewed changes
nix/sources.nix Outdated
if hasNixpkgsPath
then
if hasThisAsNixpkgsPath
then import (builtins_fetchTarball { inherit (sources.nixpkgs) url sha256; }) {}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use sources_nixpkgs

@nlewo
Copy link
Collaborator

nlewo commented Apr 8, 2019

It would be nice to fallback on builtins when possible and also explain a bit how this is working. See commit d7a25ec.

@nmattia nmattia mentioned this pull request Apr 10, 2019
Closed
@nmattia nmattia merged commit 29e351c into master Apr 10, 2019
@nmattia nmattia deleted the nm-fix-nixpkgs-fetch branch April 10, 2019 21:14
@nmattia nmattia mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmattia @nlewo