Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to do list client #122

Merged
merged 5 commits into from
Apr 9, 2020
Merged

add to do list client #122

merged 5 commits into from
Apr 9, 2020

Conversation

jeremybeier
Copy link
Contributor

Add ToDoListClient and filter query.

// I was missing this feature for a personal status display

@codecov-io
Copy link

codecov-io commented Mar 7, 2020

Codecov Report

Merging #122 into master will increase coverage by 1.02%.
The diff coverage is 95.58%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   71.06%   72.08%   +1.02%     
==========================================
  Files         151      155       +4     
  Lines        2139     2207      +68     
==========================================
+ Hits         1520     1591      +71     
+ Misses        619      616       -3
Impacted Files Coverage Δ
src/GitLabApiClient/GitLabClient.cs 98.78% <100%> (+0.04%) ⬆️
src/GitLabApiClient/ToDoListClient.cs 100% <100%> (ø)
...c/GitLabApiClient/Internal/Utilities/Extensions.cs 100% <100%> (ø) ⬆️
...t/Models/ToDoList/Requests/ToDoListQueryOptions.cs 100% <100%> (ø)
...ApiClient/Internal/Queries/ToDoListQueryBuilder.cs 100% <100%> (ø)
.../GitLabApiClient/Models/ToDoList/Responses/ToDo.cs 88.46% <88.46%> (ø)
... and 2 more

Copy link
Collaborator

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, two minor nits

@jetersen jetersen changed the title Feat/add to do list client add to do list client Apr 9, 2020
@jetersen jetersen merged commit c19e86f into nmklotas:master Apr 9, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants