Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project import export #92

Merged
merged 10 commits into from
Sep 2, 2020
Merged

Conversation

sandercox
Copy link
Contributor

Added support to do Project exports and Project imports to move projects between two gitlab hosts

@jetersen jetersen self-requested a review November 14, 2019 22:11
@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #92 into master will decrease coverage by 2.62%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   70.01%   67.38%   -2.63%     
==========================================
  Files         131      135       +4     
  Lines        1904     1987      +83     
==========================================
+ Hits         1333     1339       +6     
- Misses        571      648      +77
Impacted Files Coverage Δ
...piClient/Models/Projects/Responses/ImportStatus.cs 0% <0%> (ø)
...piClient/Models/Projects/Responses/ExportStatus.cs 0% <0%> (ø)
src/GitLabApiClient/ProjectsClient.cs 64.83% <0%> (-25.94%) ⬇️
...t/Models/Projects/Requests/ImportProjectRequest.cs 0% <0%> (ø)
...ApiClient/Models/Projects/Responses/ExportLinks.cs 0% <0%> (ø)
src/GitLabApiClient/GitLabClient.cs 72.3% <100%> (+0.43%) ⬆️
...itLabApiClient/Internal/Http/GitlabApiRequestor.cs 72.41% <26.31%> (-13.1%) ⬇️
.../GitLabApiClient/Internal/Http/GitLabHttpFacade.cs 61.53% <50%> (-4.18%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f20508...1307642. Read the comment docs.

@jetersen
Copy link
Collaborator

Hi @sandercox
I'd appreciate if you could increase the diff coverage 🙏

@sandercox
Copy link
Contributor Author

Glad to help with that but have no clue how to setup the testing environment for this... 🙈

@jetersen
Copy link
Collaborator

jetersen commented Jan 2, 2020

@sandercox see #99 (comment)

Basically the testing environment is provided for you by our unit tests as long as you have docker installed.

I'll include in the contributing.md 👍

@jetersen
Copy link
Collaborator

Would you mind resolving the conflicts?

Conflicts:
	src/GitLabApiClient/GitLabClient.cs
	src/GitLabApiClient/Internal/Http/GitLabHttpFacade.cs
	src/GitLabApiClient/ProjectsClient.cs
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #92 into master will increase coverage by 0.86%.
The diff coverage is 96.59%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   70.84%   71.71%   +0.86%     
==========================================
  Files         170      174       +4     
  Lines        2367     2450      +83     
==========================================
+ Hits         1677     1757      +80     
- Misses        690      693       +3     
Impacted Files Coverage Δ
.../GitLabApiClient/Internal/Http/GitLabHttpFacade.cs 95.55% <83.33%> (-2.01%) ⬇️
...piClient/Models/Projects/Responses/ImportStatus.cs 87.50% <87.50%> (ø)
...piClient/Models/Projects/Responses/ExportStatus.cs 88.88% <88.88%> (ø)
src/GitLabApiClient/GitLabClient.cs 97.72% <100.00%> (+0.02%) ⬆️
...itLabApiClient/Internal/Http/GitlabApiRequestor.cs 94.25% <100.00%> (+1.49%) ⬆️
...t/Models/Projects/Requests/ImportProjectRequest.cs 100.00% <100.00%> (ø)
...ApiClient/Models/Projects/Responses/ExportLinks.cs 100.00% <100.00%> (ø)
src/GitLabApiClient/ProjectsClient.cs 86.86% <100.00%> (+4.67%) ⬆️
... and 2 more

@sandercox
Copy link
Contributor Author

Updated the conflicts and added a unittest for export/import of a project. Hope this can be merged now!

@jetersen jetersen merged commit 8121a9a into nmklotas:master Sep 2, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants