Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runners and job models and some queries #93

Merged
merged 9 commits into from
Feb 17, 2020

Conversation

jadentom
Copy link
Contributor

@jadentom jadentom commented Dec 2, 2019

Added runner and job models. Also added some API queries for both runners and jobs.

No unit tests. I get a "no main()" error when I try to run them so I haven't tried.

@jetersen
Copy link
Collaborator

jetersen commented Dec 2, 2019

link to see current commit author: https://github.com/nmklotas/GitLabApiClient/pull/93/commits/12cb9ca5e7ab6ef7e4451e7086598d4983764f76.patch

@jadentom
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

@jetersen
Copy link
Collaborator

jetersen commented Dec 2, 2019

also build fails to compile on appveyor :)

@jadentom
Copy link
Contributor Author

jadentom commented Dec 2, 2019 via email

@jadentom
Copy link
Contributor Author

jadentom commented Dec 2, 2019

Closing to resubmit with amended commits.

@jadentom jadentom closed this Dec 2, 2019
@jadentom
Copy link
Contributor Author

jadentom commented Dec 2, 2019

Fixed build. Also added alias to my account thanks @Casz

@jadentom jadentom reopened this Dec 2, 2019
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #93 into master will increase coverage by 2.56%.
The diff coverage is 88.61%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   68.21%   70.77%   +2.56%     
==========================================
  Files         137      149      +12     
  Lines        1963     2118     +155     
==========================================
+ Hits         1339     1499     +160     
+ Misses        624      619       -5
Impacted Files Coverage Δ
...t/Models/Webhooks/Requests/CreateWebhookRequest.cs 0% <ø> (ø) ⬆️
...odels/Issues/Requests/ProjectIssuesQueryOptions.cs 0% <ø> (-100%) ⬇️
...Client/Models/Oauth/Requests/AccessTokenRequest.cs 100% <100%> (ø)
.../GitLabApiClient/Internal/Http/GitLabHttpFacade.cs 95.55% <100%> (+29.84%) ⬆️
src/GitLabApiClient/GitLabClient.cs 98.73% <100%> (+27.09%) ⬆️
.../Models/Groups/Requests/GroupLabelsQueryOptions.cs 100% <100%> (ø)
src/GitLabApiClient/TreesClient.cs 100% <100%> (ø)
...piClient/Models/Trees/Requests/TreeQueryOptions.cs 100% <100%> (ø)
...tLabApiClient/Internal/Queries/TreeQueryBuilder.cs 100% <100%> (ø)
...Client/Internal/Queries/GroupLabelsQueryBuilder.cs 100% <100%> (ø)
... and 27 more

@jetersen
Copy link
Collaborator

jetersen commented Dec 26, 2019

@jadentom perhaps you could improve the diff coverage by adding some tests? 🤔
I'd appreciate 100% diff coverage

@jadentom
Copy link
Contributor Author

@Casz not sure how to run the unit tests. I get a "no main()" error whenever I try.

@jetersen
Copy link
Collaborator

dotnet test should do the trick.

what IDE/editor are you using?

@jetersen
Copy link
Collaborator

& dotnet test --verbosity normal --settings coverletArgs.runsettings --no-build --no-restore

does the trick :)

@jadentom
Copy link
Contributor Author

@Casz
image my bad, it's not that the tests don't run it's that I can't build in the first place. I'm on dotnet core 3.1.100 so that shouldn't be the issue.

@jadentom
Copy link
Contributor Author

Although as a work-around dotnet test runs perfectly on my personal windows box. I guess I can use that for now.

@jetersen
Copy link
Collaborator

That error does not show up on in the GitHub CI which runs on ubuntu 18.04

@jetersen
Copy link
Collaborator

@jadentom what version of ubuntu are you using?

@jadentom
Copy link
Contributor Author

@Casz 16.04

@jetersen
Copy link
Collaborator

That might be your issue 🤔 I only tested this on 18.04

@jetersen jetersen merged commit 8d8e88c into nmklotas:master Feb 17, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants