-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runners and job models and some queries #93
Conversation
link to see current commit author: https://github.com/nmklotas/GitLabApiClient/pull/93/commits/12cb9ca5e7ab6ef7e4451e7086598d4983764f76.patch @jadentom Or look into fixing your git user.email config 😅 to get proper credit for your commits 🏆 |
also build fails to compile on appveyor :) |
Thanks I'll check both of those out. It compiles as part of my project but
I probably should have submitted it as a draft anyways 😅.
…On Mon, Dec 2, 2019, 4:59 PM Joseph Petersen ***@***.***> wrote:
also build fails to compile on appveyor :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93?email_source=notifications&email_token=ABVPRYBVU2GKQ5JGOXM4PFDQWWALNA5CNFSM4JUKD372YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFVXH5I#issuecomment-560690165>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVPRYB62EVBA7FD5O4ZUQDQWWALNANCNFSM4JUKD37Q>
.
|
Closing to resubmit with amended commits. |
Fixed build. Also added alias to my account thanks @Casz |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 68.21% 70.77% +2.56%
==========================================
Files 137 149 +12
Lines 1963 2118 +155
==========================================
+ Hits 1339 1499 +160
+ Misses 624 619 -5
|
@jadentom perhaps you could improve the diff coverage by adding some tests? 🤔 |
@Casz not sure how to run the unit tests. I get a "no main()" error whenever I try. |
what IDE/editor are you using? |
Line 3 in 2f20508
does the trick :) |
@Casz |
Although as a work-around dotnet test runs perfectly on my personal windows box. I guess I can use that for now. |
That error does not show up on in the GitHub CI which runs on ubuntu 18.04 |
@jadentom what version of ubuntu are you using? |
@Casz 16.04 |
That might be your issue 🤔 I only tested this on 18.04 |
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Added runner and job models. Also added some API queries for both runners and jobs.
No unit tests. I get a "no main()" error when I try to run them so I haven't tried.