Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thirdPartyAddress to the Attribute's shareInfo #282

Merged
merged 47 commits into from
Oct 21, 2024
Merged

Add thirdPartyAddress to the Attribute's shareInfo #282

merged 47 commits into from
Oct 21, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Sep 23, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the enhancement New feature or request label Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.48624% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/src/modules/attributes/local/LocalAttribute.ts 70.37% 8 Missing ⚠️
...areAttribute/ShareAttributeRequestItemProcessor.ts 42.85% 8 Missing ⚠️
packages/runtime/src/dataViews/DataViewExpander.ts 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...ion/src/modules/attributes/AttributesController.ts 91.06% <100.00%> (+0.01%) ⬆️
...tributes/local/CreateSharedLocalAttributeParams.ts 95.55% <100.00%> (+0.68%) ⬆️
...odules/attributes/local/LocalAttributeShareInfo.ts 80.00% <100.00%> (+1.21%) ⬆️
...readAttribute/ReadAttributeRequestItemProcessor.ts 91.13% <100.00%> (+0.36%) ⬆️
...s/readAttribute/ReadAttributeAcceptResponseItem.ts 85.71% <100.00%> (+2.38%) ⬆️
.../items/shareAttribute/ShareAttributeRequestItem.ts 90.24% <100.00%> (+1.67%) ⬆️
.../dataViews/consumption/DecidableRequestItemDVOs.ts 100.00% <100.00%> (ø)
...ime/src/dataViews/consumption/LocalAttributeDVO.ts 100.00% <100.00%> (ø)
...s/runtime/src/dataViews/content/RequestItemDVOs.ts 100.00% <100.00%> (ø)
.../runtime/src/dataViews/content/ResponseItemDVOs.ts 100.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

@jkoenig134
Copy link
Member

@sebbi08 please make sure that your pipelines pass before assigning a PR to anyone.

Magnus-Kuhn
Magnus-Kuhn reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accept sections of the Read- and ShareAttributeItemProcessors need tests that the thirdParty is set correctly

...ion/src/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.ts Outdated Show resolved Hide resolved
packages/consumption/src/modules/attributes/local/CreateSharedLocalAttributeCopyParams.ts Outdated Show resolved Hide resolved
packages/consumption/src/modules/attributes/local/CreateSharedLocalAttributeParams.ts Outdated Show resolved Hide resolved
packages/consumption/src/modules/attributes/local/LocalAttributeShareInfo.ts Outdated Show resolved Hide resolved
packages/runtime/src/modules/AttributeListenerModule.ts Show resolved Hide resolved
packages/runtime/src/types/consumption/LocalAttributeDTO.ts Show resolved Hide resolved
packages/content/src/requests/items/shareAttribute/ShareAttributeRequestItem.ts Show resolved Hide resolved
@Magnus-Kuhn
Copy link
Contributor

Magnus-Kuhn commented Sep 25, 2024 •
edited
Loading

Slightly related: Why don't we have a use case for sharing a RelationshipAttribute? Right now it's done by building a request.

Also do we intend to use this new thirdPartyAddress for queries or something? Right now it only exists.

sebbi08 and others added 3 commits September 30, 2024 07:59
@sebbi08 @Magnus-Kuhn
Update packages/consumption/src/modules/attributes/local/CreateShared…
f499978 
…LocalAttributeCopyParams.ts

Co-authored-by: Magnus Kuhn <127854942+Magnus-Kuhn@users.noreply.github.com>
@sebbi08 @Magnus-Kuhn
Update packages/consumption/src/modules/attributes/local/CreateShared…
9bd016e 
…LocalAttributeParams.ts

Co-authored-by: Magnus Kuhn <127854942+Magnus-Kuhn@users.noreply.github.com>
@sebbi08 @Magnus-Kuhn
Update packages/consumption/src/modules/attributes/local/LocalAttribu…
057429a 
…teShareInfo.ts

Co-authored-by: Magnus Kuhn <127854942+Magnus-Kuhn@users.noreply.github.com>
@sebbi08
Copy link
Contributor Author

sebbi08 commented Sep 30, 2024

Slightly related: Why don't we have a use case for sharing a RelationshipAttribute? Right now it's done by building a request.

Also do we intend to use this new thirdPartyAddress for queries or something? Right now it only exists.

We are currently in the evaluation of such "shortcut usecases" they might not be part of the runtime.

The third party address is currently only prerequisites for some other tickets in regard to validation.

@britsta
Copy link
Contributor

britsta commented Oct 15, 2024

I just noticed, you forgot to update the DVOs with the new property

This especially applies to the DecidableShareAttributeRequestItemDVO (DecidableRequestItemDVOs.ts), ShareAttributeRequestItemDVO (RequestItemDVOs.ts) and ReadAttributeAcceptResponseItemDVO (ResponseItemDVOs.ts).

@sebbi08 sebbi08 enabled auto-merge (squash) October 18, 2024 10:22
@jkoenig134 jkoenig134 changed the title Add third party address to the attribute shareInfo Add thirdPartyAddress to the Attribute's shareInfo Oct 18, 2024
britsta
britsta reviewed Oct 18, 2024
View reviewed changes
packages/consumption/src/modules/attributes/local/LocalAttribute.ts Outdated Show resolved Hide resolved
packages/consumption/src/modules/attributes/local/LocalAttribute.ts Outdated Show resolved Hide resolved
...ption/src/modules/requests/itemProcessors/readAttribute/ReadAttributeRequestItemProcessor.ts Show resolved Hide resolved
...ption/src/modules/requests/itemProcessors/readAttribute/ReadAttributeRequestItemProcessor.ts Show resolved Hide resolved
...ion/src/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.ts Outdated Show resolved Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts Show resolved Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts Show resolved Hide resolved
...ion/src/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.ts Outdated Show resolved Hide resolved
packages/runtime/test/consumption/attributes.test.ts Outdated Show resolved Hide resolved
packages/runtime/test/consumption/attributes.test.ts Outdated Show resolved Hide resolved
britsta
britsta approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳

@sebbi08 sebbi08 merged commit 46a256c into main Oct 21, 2024
18 checks passed
@sebbi08 sebbi08 deleted the feature/add_third_party_adress_to_share_info branch October 21, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuthDiG RuthDiG RuthDiG left review comments

@Magnus-Kuhn Magnus-Kuhn Magnus-Kuhn left review comments

@britsta britsta britsta approved these changes

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski left review comments

@jkoenig134 jkoenig134 Awaiting requested review from jkoenig134

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebbi08 @jkoenig134 @Magnus-Kuhn @britsta @Milena-Czierlinski @RuthDiG