Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Add plugin for yocto-kas build #702

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Feb 2, 2021

  • Add postbuild plugin for yocto image build
  • This plugin utilize python module "kas" to build yocto image
  • This plugin can be used for build check custom yocto layer
  • Add guide yml config files for kas build

REF:

  • kas: github.com/siemens/kas

Please check:
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6

Signed-off-by: Yongjoo Ahn yongjoo1.ahn@samsung.com

Self evaluation:
Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 2, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #702. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

@@ -76,3 +76,9 @@ echo "[MODULE] plugins-staging: Plugin group that does not have evaluation and a
# echo "[DEBUG] Current path: $(pwd)."
# source ${REFERENCE_REPOSITORY}/ci/taos/plugins-staging/${postbuild_plugins[idx]}.sh


postbuild_plugins[++idx]="pr-postbuild-build-yocto-kas"
Copy link
Collaborator

@leemgs leemgs Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to enable this module by default? You need to append annotation (e.g., #) because this module will be applied to the existing TAOS-CI in real-time.
Note that the pr-postbuild-build-yocto-kas.sh file will meet errors due to the not-installed packages.

# $ sudo apt-get -y install gawk wget git-core diffstat unzip texinfo gcc-multilib
# $ sudo apt-get -y install build-essential chrpath socat libsdl1.2-dev xterm
# $ sudo pip3 install kas

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I commented out this new module.

header:
version: 2

distro: poky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. 🥇

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

@@ -0,0 +1,102 @@
#!/usr/bin/env bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR. 🥇

@leemgs
Copy link
Collaborator

leemgs commented Feb 3, 2021

Please check:
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6

@anyj0527 , Could you upload the execution result (See below your work: two PRs) of the self-assessment here in order that I merge this PR finally? 🏎️

  • [FYI] The below screenshot shows I captured on Feb-05-2021 at 09:00.

image

image

# NOTE that the value of url should be "PATH_WILL_BE_REPLACED_BY_CI".
# The TAOS-CI replace this string with proper path for submitted PR
#
# REF: https://github.com/siemens/kas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helloahn , Could you add info on KAS for maintenance?:) For example,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion! I updated the file. Please check.

@@ -0,0 +1,18 @@
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add new file as follows for maintenance and convenience?

$ cd .../kas-files/
$ vi README.md
This folder is created to run plugins-staging/pr-postbuild-build-yocto-kas.sh.
The YAML files are to be used as a configuration file.
 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I added a README.md

@anyj0527
Copy link
Member Author

anyj0527 commented Feb 5, 2021

@leemgs

For https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6 :

You can check the build log for intended failure in ........../report/build_log_{PR_NUMBER}_yocto_kas_log.txt:

...
2021-02-02 17:48:15 - ERROR    - ERROR: ParseError at /var/www/html/meta-neural-network-yongjoo/TAOS-CI/ci/repo-workers/pr-checker/6-202102021748030.76346206665039-0f3124a09f6f3c91e65415e92be05c7ef63655c2/meta-neural-network-yongjoo/kas-build/meta-neural-network/recipes-nnstreamer/nnstreamer/nnstreamer_1.7.0.bb:10: unparsed line: 'This line fails CI build test'
2021-02-02 17:48:17 - INFO     - Parsing recipes...
2021-02-02 17:48:17 - INFO     - Summary: There was 1 ERROR message shown, returning a non-zero exit code.
2021-02-02 17:48:17 - ERROR    - Command "/var/www/html/meta-neural-network-yongjoo/TAOS-CI/ci/repo-workers/pr-checker/6-202102021748030.76346206665039-0f3124a09f6f3c91e65415e92be05c7ef63655c2/meta-neural-network-yongjoo/kas-build/build$ /var/www/html/meta-neural-network-yongjoo/TAOS-CI/ci/repo-workers/pr-checker/6-202102021748030.76346206665039-0f3124a09f6f3c91e65415e92be05c7ef63655c2/meta-neural-network-yongjoo/kas-build/poky/bitbake/bin/bitbake -k -c build core-image-minimal" failed
--- Error summary ---
ERROR: ParseError at /var/www/html/meta-neural-network-yongjoo/TAOS-CI/ci/repo-workers/pr-checker/6-202102021748030.76346206665039-0f3124a09f6f3c91e65415e92be05c7ef63655c2/meta-neural-network-yongjoo/kas-build/meta-neural-network/recipes-nnstreamer/nnstreamer/nnstreamer_1.7.0.bb:10: unparsed line: 'This line fails CI build test'

For https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7 :

You can check the built packages and image in ........../meta-neural-network-yongjoo/kas-build/build/tmp/deploy/*:

$ cd ~/html/meta-neural-network-yongjoo/ci/repo-workers/pr-checker/7-202102050946360.75058197975159-ddf23f2b556b7653aa4c857d81a2f6d2c6d30221/meta-neural-network-yongjoo/kas-build/build/tmp/deploy/rpm/aarch64
$ ls | grep nnstreamer
nnstreamer-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-dbg-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-dev-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-src-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-staticdev-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-tensorflow-lite-1.7.0+git0+d14c6892c2-r0.aarch64.rpm
nnstreamer-unittest-1.7.0+git0+d14c6892c2-r0.aarch64.rpm

$ cd ~/html/meta-neural-network-yongjoo/ci/repo-workers/pr-checker/7-202102050946360.75058197975159-ddf23f2b556b7653aa4c857d81a2f6d2c6d30221/meta-neural-network-yongjoo/kas-build/build/tmp/deploy/images/qemuarm64
$ ls
core-image-minimal-qemuarm64-20210205004756.qemuboot.conf
core-image-minimal-qemuarm64-20210205004756.rootfs.ext4
core-image-minimal-qemuarm64-20210205004756.rootfs.manifest
core-image-minimal-qemuarm64-20210205004756.rootfs.tar.bz2
core-image-minimal-qemuarm64-20210205004756.testdata.json
core-image-minimal-qemuarm64.ext4@
core-image-minimal-qemuarm64.manifest@
core-image-minimal-qemuarm64.qemuboot.conf@
core-image-minimal-qemuarm64.tar.bz2@
core-image-minimal-qemuarm64.testdata.json@
Image@
Image--5.2.32+git0+bb2776d6be_73b12de4c8-r0-qemuarm64-20210128043933.bin
Image-qemuarm64.bin@
modules--5.2.32+git0+bb2776d6be_73b12de4c8-r0-qemuarm64-20210128043933.tgz
modules-qemuarm64.tgz@

Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Proceed when @leemgs says it's resolved.

- Add postbuild plugin for yocto image build
- This plugin utilize python module "kas" to build yocto image
- This plugin can be used for build check custom yocto layer
- Add guide yml config files for kas build

REF:
- kas: github.com/siemens/kas
- config files:
  https://kas.readthedocs.io/en/latest/userguide.html#project-configuration

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

@leemgs
Copy link
Collaborator

leemgs commented Feb 5, 2021

Please check:
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6

@anyj0527 , Could you upload the execution result (See below your work: two PRs) of the self-assessment here in order that I merge this PR finally? 🏎️

  • [FYI] The below screenshot shows I captured on Feb-05-2021 at 09:00.

image

image

@anyj0527 , PTAL. REMINDER V2.

@anyj0527
Copy link
Member Author

anyj0527 commented Feb 5, 2021

@leemgs

I don't know what exactly self assessment is.
Does #702 (comment) not enough?
I could boot qemu with built image.

BTW I'm @anyj0527 not @helloahn . it's Hyoungjoo :)

@leemgs
Copy link
Collaborator

leemgs commented Feb 5, 2021

I don't know what exactly self assessment is.

The self-assessment means that you verified by testing in your local PC
to avoid an integration issue due to incorrect PRs.
[FYI] https://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/self-assessment-before-submitting-pr.md

Does #702 (comment) not enough?
I could boot qemu with built image.

I checked that you added your locat test now at the below address. Acked-by: Geunsik Lim.
#702 (comment)

BTW I'm @anyj0527 not @helloahn .

Pardon me. 😅 Replaced above. (s/helloahn/anyj0527)

Copy link
Collaborator

@leemgs leemgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Geunsik Lim geunsik.lim@samsung.com

🉑 , Thank you for your excellent contribution to the Yocto-based clean build.

@leemgs
Copy link
Collaborator

leemgs commented Feb 5, 2021

@anyj0527 , I like yocto-kas (new module). Could you append a summary on the yocto-kas module at the below wiki page?

@anyj0527
Copy link
Member Author

anyj0527 commented Feb 5, 2021

@leemgs
Thanks! I added a summary.

@leemgs leemgs merged commit e367a97 into nnstreamer:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants