-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Add plugin for yocto-kas build #702
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #702. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anyj0527, 💯 All CI checkers are successfully verified. Thanks.
@@ -76,3 +76,9 @@ echo "[MODULE] plugins-staging: Plugin group that does not have evaluation and a | |||
# echo "[DEBUG] Current path: $(pwd)." | |||
# source ${REFERENCE_REPOSITORY}/ci/taos/plugins-staging/${postbuild_plugins[idx]}.sh | |||
|
|||
|
|||
postbuild_plugins[++idx]="pr-postbuild-build-yocto-kas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to enable this module by default? You need to append annotation (e.g., #) because this module will be applied to the existing TAOS-CI in real-time.
Note that the pr-postbuild-build-yocto-kas.sh file will meet errors due to the not-installed packages.
# $ sudo apt-get -y install gawk wget git-core diffstat unzip texinfo gcc-multilib
# $ sudo apt-get -y install build-essential chrpath socat libsdl1.2-dev xterm
# $ sudo pip3 install kas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I commented out this new module.
header: | ||
version: 2 | ||
|
||
distro: poky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. 🥇
532cbb9
to
bd28b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anyj0527, 💯 All CI checkers are successfully verified. Thanks.
@@ -0,0 +1,102 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR. 🥇
@anyj0527 , Could you upload the execution result (See below your work: two PRs) of the self-assessment here in order that I merge this PR finally? 🏎️
|
# NOTE that the value of url should be "PATH_WILL_BE_REPLACED_BY_CI". | ||
# The TAOS-CI replace this string with proper path for submitted PR | ||
# | ||
# REF: https://github.com/siemens/kas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@helloahn , Could you add info on KAS for maintenance?:) For example,
- before : REF: https://github.com/siemens/kas
- after : Reference - https://github.com/siemens/kas (Setup tool for bitbake based projects)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion! I updated the file. Please check.
@@ -0,0 +1,18 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add new file as follows for maintenance and convenience?
$ cd .../kas-files/
$ vi README.md
This folder is created to run plugins-staging/pr-postbuild-build-yocto-kas.sh.
The YAML files are to be used as a configuration file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I added a README.md
For https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6 : You can check the build log for intended failure in
For https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7 : You can check the built packages and image in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Proceed when @leemgs says it's resolved.
- Add postbuild plugin for yocto image build - This plugin utilize python module "kas" to build yocto image - This plugin can be used for build check custom yocto layer - Add guide yml config files for kas build REF: - kas: github.com/siemens/kas - config files: https://kas.readthedocs.io/en/latest/userguide.html#project-configuration Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
bd28b51
to
fe21aa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anyj0527, 💯 All CI checkers are successfully verified. Thanks.
@anyj0527 , PTAL. REMINDER V2. |
I don't know what exactly self assessment is. |
The self-assessment means that you verified by testing in your local PC
I checked that you added your locat test now at the below address. Acked-by: Geunsik Lim. Pardon me. 😅 Replaced above. (s/helloahn/anyj0527) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
🉑 , Thank you for your excellent contribution to the Yocto-based clean build.
@anyj0527 , I like yocto-kas (new module). Could you append a summary on the yocto-kas module at the below wiki page? |
@leemgs |
REF:
Please check:
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/7
https://github.sec.samsung.net/yongjoo1-ahn/meta-neural-network-yongjoo/pull/6
Signed-off-by: Yongjoo Ahn yongjoo1.ahn@samsung.com
Self evaluation:
Run test: [X]Passed [ ]Failed [ ]Skipped