Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Structure] Add CCPP Drivers #32

Open
drnimbusrain opened this issue Oct 20, 2022 · 7 comments
Open

[Structure] Add CCPP Drivers #32

drnimbusrain opened this issue Oct 20, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@drnimbusrain
Copy link
Member

drnimbusrain commented Oct 20, 2022

@zmoon Maybe we can close/combine other issues under this larger one in the attempt to conform the canopy_app structure to be more easily adaptable to CCPPv6 standards:

See the paper, Figure 1, and Listings 2 -4 (e.g., Listing 2: A complete CCPP-compliant parameterization with Fortran source code)
https://egusphere.copernicus.org/preprints/2022/egusphere-2022-855/egusphere-2022-855.pdf

@zmoon
Copy link
Member

zmoon commented Oct 20, 2022

There is overlap, but also some aspects here that are at least somewhat separate, i.e.

  • providing a public API suitable for using from the CCPP scheme context
  • checking Fortran standard, etc.

So I would vote to leave the standalone restructuring for one open for now.

@drnimbusrain drnimbusrain added help wanted Extra attention is needed enhancement New feature or request labels Nov 1, 2022
@drnimbusrain
Copy link
Member Author

@zmoon I think this is a big one that still needs work. Looking forward to more on this one.

@zmoon
Copy link
Member

zmoon commented Feb 15, 2023

I'll be thinking about this one and #21 #23 #31 together.

@drnimbusrain drnimbusrain changed the title Conform Code Structure to CCPP Standards Conform Code Structure to CCPP Standards with Wrappers Jun 30, 2023
@drnimbusrain
Copy link
Member Author

@zmoon Do you think we can bring in some of the CCPP wrapper work that you and Barry have been doing for Fengsha? https://github.com/bbakernoaa/fengsha_ccpp or specifically, https://github.com/bbakernoaa/fengsha_ccpp/blob/main/driver/ccpp/catchem_dust_wrapper.F90%20?

I think this would be useful for upcoming work/presentations to show the potential for starting to bring in canopy-app to UFS in this way using CCPP.

@zmoon
Copy link
Member

zmoon commented Jul 3, 2023

Something to note is that to follow Barry's CCPP wrapper conventions we need to have a routine that does all of the calculations for a single point. A "public API" method, like we have discussed in the past. #23

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Jul 3, 2023 via email

@drnimbusrain drnimbusrain changed the title Conform Code Structure to CCPP Standards with Wrappers [Structure] Conform Code to CCPP Standards with Wrappers Sep 6, 2023
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Sep 8, 2023

@zmoon I'd like to get started on this part pretty soon, are there any suggestions for the "public API" methods associated with #23 for canopy-app that you can give?

@drnimbusrain drnimbusrain changed the title [Structure] Conform Code to CCPP Standards with Wrappers [Structure] Add CCPP Drivers using Standards with Wrappers Nov 1, 2023
@drnimbusrain drnimbusrain changed the title [Structure] Add CCPP Drivers using Standards with Wrappers [Structure] Add CCPP Drivers Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants