Refactor/webpack - Actions, reducers lintable, alerts in progress #805
Conversation
|
lgtm |
|
@maxyeo - before this is merged can you please pull and ensure that the push notifications still occur correctly. Since I am not on SSL server I don't believe mine is working and I cannot test. If you cannot test locally we will deploy to staging and test there. In any case please lmk ASAP as this PR has a bug fix for prod (switching semester is not working). |
| @@ -22,151 +22,143 @@ const DAY_MAP = { | |||
| U: 'su', | |||
| }; | |||
|
|
|||
| function getNextDayOfWeek(date, dayOfWeek) { | |||
| export const getNextDayOfWeek = (date, dayOfWeek) => { | |||
There was a problem hiding this comment.
I don't see a reason for this to be an arrow function but I also don't see anything that says that arrow functions should be reserved for curried/anonymous/single expression functions.
So this is fine if we decide that all functions from now on should be written as arrow functions.
My personal preference would be to use the const foo = function foo() {} syntax since:
it lets you use a short variable name, but a long, verbose, unique function name; also, when self-referencing the function, it makes it very clear that you're referring to the lexical name binding, not the containing variable.
|
lgtm |
No description provided.