Skip to content

fix_undefined_pwd_function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2014
Merged

fix_undefined_pwd_function #1

merged 1 commit into from
Jan 1, 2014

Conversation

aleafs
Copy link
Contributor

@aleafs aleafs commented Dec 31, 2013

nae-fs create without pwd option causes a fatal error

@ghost ghost assigned fengmk2 Dec 31, 2013
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cd1283e on fix_undefined_pwd_function into 56923ac on master.

@fengmk2
Copy link
Member

fengmk2 commented Dec 31, 2013

这个参数我想是在这个模块初始化的时候赋值的

@aleafs
Copy link
Contributor Author

aleafs commented Jan 1, 2014

我明白的。但是从代码角度来讲，应该保证任何一个分支都不出现非逻辑层面的异常。

fengmk2 added a commit that referenced this pull request Jan 1, 2014
@fengmk2
Merge pull request #1 from node-app-engine/fix_undefined_pwd_function
533c747 
fix_undefined_pwd_function
@fengmk2 fengmk2 merged commit 533c747 into master Jan 1, 2014
@fengmk2
Copy link
Member

fengmk2 commented Jan 1, 2014

好，+1
2014-1-1 AM10:32于 "aleafs" notifications@github.com写道：

我明白的。但是从代码角度来讲，应该保证任何一个分支都不出现非逻辑层面的异常。

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-31417574
.

@aleafs aleafs deleted the fix_undefined_pwd_function branch January 1, 2014 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleafs @coveralls @fengmk2