New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): readObject [byte -> Buffer #10

Merged
merged 2 commits into from Dec 1, 2014

Conversation

Projects
None yet
2 participants
@coolme200

coolme200 commented Dec 1, 2014

[1,2,3] cannot correctly judge the Buffer or int array

@fengmk2 fengmk2 changed the title from feat(input): readObject byte -> Buffer to feat(input): readObject [byte -> Buffer Dec 1, 2014

@fengmk2 fengmk2 added the enhancement label Dec 1, 2014

@fengmk2 fengmk2 self-assigned this Dec 1, 2014

Show outdated Hide outdated lib/input.js Outdated
@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Dec 1, 2014

Member

This incompatible feature, after merge, will publish a new major version

Member

fengmk2 commented Dec 1, 2014

This incompatible feature, after merge, will publish a new major version

@fengmk2 fengmk2 added the incompatible label Dec 1, 2014

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Dec 1, 2014

Member

+1

Member

fengmk2 commented Dec 1, 2014

+1

fengmk2 added a commit that referenced this pull request Dec 1, 2014

Merge pull request #10 from node-modules/buffer
feat(input): readObject [byte -> Buffer

@fengmk2 fengmk2 merged commit efc179b into master Dec 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the buffer branch Dec 1, 2014

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Dec 1, 2014

Member

2.0.0 published

Member

fengmk2 commented Dec 1, 2014

2.0.0 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment