feat(valid): #5 support valid & Null valud #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
先看下这个重构方式，测试用例我再考虑下。 |
| if (typeof type === 'string') { | ||
| type = { | ||
| name: type, | ||
| valid: foo |
|
@coolme200 看一下刚才说的那几个问题，其他都ok |
|
好，我看下。 |
|
+1 |
dead-horse
added a commit
that referenced
this pull request
Jan 22, 2015
feat(valid): #5 support valid & Null valud
|
突然发现一个问题，这里做完强制类型转换，排查问题也比较麻烦啊，如果把 string 转成了 int 变成 NaN 的时候会出现什么状况 |
|
如果是 NaN 的话好办，会跟不做类型转换的时候报一样的错，序列化失败。 另外排查问题的一般方法是先拿客户端请求过去的内容和服务端接收到的数据进行比较，如果发现不一致再往下查，问题还是比较容易定位的。 |
|
ok 先这样吧，我发个2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.