Don't create new zk client on states: closing, expire, auth_failed #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wision Could you please add a description? (Agree the title explains, but also...) |
|
@hemanth done |
|
👍 |
hemanth
added a commit
that referenced
this pull request
Jan 28, 2015
Don't create new zk client on states: closing, expire, auth_failed.
|
@fengmk2 |
|
release patch version 1.0.1 |
|
@wision also add you @node-modules/dev team |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-zookeeper-client is already handling disconnects and to everyone else, it appears either connected or connecting (alexguan/node-zookeeper-client#15 (comment)), so there's no need to handle it in the watcher.. this doesn't apply on states: closing, expire, auth_failed
the problem is that we are experiencing increasing number of connections when restarting zookeeper where client reconnects after 2-3seconds, and then watcher creates new connection after 20secs
can you please review this?