-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle arrays like objects in match_body #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks god. Would you mind adding a couple of tests regarding this?
*Code looks good (damn autocorrect) |
af583e4
to
c4c5689
Compare
I added a test covering this. One layer of array should be enough, since that was all it took to cause the problem, but I'm happy to add a more complex test case if you'd like. |
Thanks for the contribution 😄 |
Published as part of v8.2.0 🎉 |
I've created a PR to fix the regression. It can be found here => #734 |
Fixes regression introduced by #719
Fixes regression introduced by #719
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Closes #715 and does not appear to cause any regressions.