Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev into master #184

Merged
merged 9 commits into from
May 30, 2023
Merged

Merge dev into master #184

merged 9 commits into from
May 30, 2023

Conversation

jankapunkt
Copy link
Member

We forgot to merge dev into master but master should reflect the latest stable (which is current dev)

@HappyZombies HappyZombies self-assigned this May 26, 2023
HappyZombies
HappyZombies previously approved these changes May 26, 2023
Copy link
Member

@HappyZombies HappyZombies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Completed

Copy link
Member

@jorenvandeweyer jorenvandeweyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should include node v20 in the test-release.yaml

@jankapunkt
Copy link
Member Author

@jorenvandeweyer you are right I will also drop node 14 in the tests as it's deprecated now.

@jankapunkt jankapunkt temporarily deployed to github-pages May 30, 2023 08:13 — with GitHub Pages Inactive
@jankapunkt jankapunkt temporarily deployed to github-pages May 30, 2023 08:15 — with GitHub Pages Inactive
@jankapunkt
Copy link
Member Author

Updated the CI to Node 20. I also used the PR to update links in the README and added this repo finally to readthedocs so we can host an up-to-date documentation.

However, for the actual documentation Update I will create another PR (there are still old links to OAuthJs etc. in the docs).

@jankapunkt
Copy link
Member Author

@HappyZombies @jorenvandeweyer can you please review again so I can merge?

@jankapunkt jankapunkt merged commit aa386b8 into master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants