Skip to content

Fix unnecessary configuration node #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Fix unnecessary configuration node #81

merged 1 commit into from
Aug 7, 2018

Conversation

kazuhitoyokoi
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

When swagger definition doesn't have host name and security setting, generated node has unnecessary configuration node (users need to input only name of configuration node). To solve the problem, I added handling to remove configuration node in the case.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.812% when pulling 74428c0 on kazuhitoyokoi:master-updateswaggertemplate into a71a7b9 on node-red:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.812% when pulling 74428c0 on kazuhitoyokoi:master-updateswaggertemplate into a71a7b9 on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.812% when pulling 74428c0 on kazuhitoyokoi:master-updateswaggertemplate into a71a7b9 on node-red:master.

@HiroyasuNishiyama HiroyasuNishiyama merged commit 6b88422 into node-red:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants