accept file-uploads through multipart/form-data requests without modifications
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@kastentx Thank you for this pull request. In terms of the test case, it seems good. I'm going to check the code next week. |
package.json
Outdated
| @@ -84,7 +84,8 @@ | |||
| "minimist": "1.2.0", | |||
| "mustache": "2.3.0", | |||
| "request": "2.83.0", | |||
| "swagger-js-codegen": "1.12.0", | |||
| "swagger-js-codegen-formdata": "^0.15.4", | |||
| "upgrade": "^1.1.0", | |||
There was a problem hiding this comment.
@kastentx I think that upgrade module is not used in the code. Could you remove it if it is mistakenly added? (Could you give me the reason if it is needed?)
There was a problem hiding this comment.
Thank you. This was added in error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94 for services with an accurately defined OpenAPI spec that accept file uploads