Skip to content

Conversation

LiSheep
Copy link
Contributor

@LiSheep LiSheep commented Oct 30, 2014

有人说List的回复的太丑了还不能定制。

lib/list.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单词写全吧,我看了半天不知道deli是什么意思

@JacksonTian
Copy link
Member

list相关的单元测试会挂吧?

@JacksonTian
Copy link
Member

patch不错。修改好了 ping我下

@LiSheep
Copy link
Contributor Author

LiSheep commented Oct 31, 2014

@JacksonTian ok修改好了~:)

lib/list.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段判断没有必要吧?

@LiSheep
Copy link
Contributor Author

LiSheep commented Nov 1, 2014

@JacksonTian 加那个是怕有人误填了参数~既然你觉得没用就删了:)

@JacksonTian
Copy link
Member

你已经兼容默认值了呀

发自我的 iPhone

在 2014年11月1日,下午2:03,ltc notifications@github.com 写道:

@JacksonTian 加那个是怕有人误填了参数~既然你觉得没用就删了:)


Reply to this email directly or view it on GitHub.

@JacksonTian
Copy link
Member

closed via 00bc69d.

@JacksonTian JacksonTian closed this Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants